code simplification

This commit is contained in:
psucien 2024-11-23 11:27:51 +01:00
parent ed1282edcc
commit 04739a3f4c

View File

@ -75,13 +75,13 @@ bool CanBlitToSwapchain(const vk::PhysicalDevice physical_device, vk::Format for
return MakeImageBlit(frame_width, frame_height, swapchain_width, swapchain_height, 0, 0); return MakeImageBlit(frame_width, frame_height, swapchain_width, swapchain_height, 0, 0);
} }
static std::tuple<s32, s32, s32, s32> FitImage(s32 frame_width, s32 frame_height, static vk::Rect2D FitImage(s32 frame_width, s32 frame_height, s32 swapchain_width,
s32 swapchain_width, s32 swapchain_height) { s32 swapchain_height) {
float frame_aspect = static_cast<float>(frame_width) / frame_height; float frame_aspect = static_cast<float>(frame_width) / frame_height;
float swapchain_aspect = static_cast<float>(swapchain_width) / swapchain_height; float swapchain_aspect = static_cast<float>(swapchain_width) / swapchain_height;
s32 dst_width = swapchain_width; u32 dst_width = swapchain_width;
s32 dst_height = swapchain_height; u32 dst_height = swapchain_height;
if (frame_aspect > swapchain_aspect) { if (frame_aspect > swapchain_aspect) {
dst_height = static_cast<s32>(swapchain_width / frame_aspect); dst_height = static_cast<s32>(swapchain_width / frame_aspect);
@ -92,15 +92,15 @@ static std::tuple<s32, s32, s32, s32> FitImage(s32 frame_width, s32 frame_height
const s32 offset_x = (swapchain_width - dst_width) / 2; const s32 offset_x = (swapchain_width - dst_width) / 2;
const s32 offset_y = (swapchain_height - dst_height) / 2; const s32 offset_y = (swapchain_height - dst_height) / 2;
return {dst_width, dst_height, offset_x, offset_y}; return vk::Rect2D{{offset_x, offset_y}, {dst_width, dst_height}};
} }
[[nodiscard]] vk::ImageBlit MakeImageBlitFit(s32 frame_width, s32 frame_height, s32 swapchain_width, [[nodiscard]] vk::ImageBlit MakeImageBlitFit(s32 frame_width, s32 frame_height, s32 swapchain_width,
s32 swapchain_height) { s32 swapchain_height) {
const auto [dst_width, dst_height, offset_x, offset_y] = const auto& dst_rect = FitImage(frame_width, frame_height, swapchain_width, swapchain_height);
FitImage(frame_width, frame_height, swapchain_width, swapchain_height);
return MakeImageBlit(frame_width, frame_height, dst_width, dst_height, offset_x, offset_y); return MakeImageBlit(frame_width, frame_height, dst_rect.extent.width, dst_rect.extent.height,
dst_rect.offset.x, dst_rect.offset.y);
} }
static vk::Format FormatToUnorm(vk::Format fmt) { static vk::Format FormatToUnorm(vk::Format fmt) {
@ -560,28 +560,22 @@ Frame* Presenter::PrepareFrameInternal(VideoCore::ImageId image_id, bool is_eop)
cmdbuf.bindPipeline(vk::PipelineBindPoint::eGraphics, *pp_pipeline); cmdbuf.bindPipeline(vk::PipelineBindPoint::eGraphics, *pp_pipeline);
const auto& [width, height, offset_x, offset_y] = const auto& dst_rect =
FitImage(image.info.size.width, image.info.size.height, frame->width, frame->height); FitImage(image.info.size.width, image.info.size.height, frame->width, frame->height);
const std::array viewports = { const std::array viewports = {
vk::Viewport{ vk::Viewport{
.x = 1.0f * offset_x, .x = 1.0f * dst_rect.offset.x,
.y = 1.0f * offset_y, .y = 1.0f * dst_rect.offset.y,
.width = 1.0f * width, .width = 1.0f * dst_rect.extent.width,
.height = 1.0f * height, .height = 1.0f * dst_rect.extent.height,
.minDepth = 0.0f, .minDepth = 0.0f,
.maxDepth = 1.0f, .maxDepth = 1.0f,
}, },
}; };
const std::array scissors = {
vk::Rect2D{
.offset = {offset_x, offset_y},
.extent = {frame->width, frame->height},
},
};
cmdbuf.setViewport(0, viewports); cmdbuf.setViewport(0, viewports);
cmdbuf.setScissor(0, scissors); cmdbuf.setScissor(0, {dst_rect});
cmdbuf.pushDescriptorSetKHR(vk::PipelineBindPoint::eGraphics, *pp_pipeline_layout, 0, cmdbuf.pushDescriptorSetKHR(vk::PipelineBindPoint::eGraphics, *pp_pipeline_layout, 0,
set_writes); set_writes);