Minor Cleanup

.github/workflows/ci.yml

@@ -1,4 +1,3 @@
-
 # SPDX-FileCopyrightText: 2021 yuzu Emulator Project
 # SPDX-License-Identifier: GPL-2.0-or-later
 

.gitmodules

@@ -46,5 +46,4 @@
 	url = https://github.com/shadps4-emu/ext-zlib-ng.git
 [submodule "externals/sdl3"]
 	path = externals/sdl3
-	url = https://github.com/shadps4-emu/ext-SDL.git
+	url = https://github.com/shadps4-emu/ext-SDL.git
-

CMakeLists.txt

@@ -1,7 +1,7 @@
 # SPDX-FileCopyrightText: Copyright 2024 shadPS4 Emulator Project
 # SPDX-License-Identifier: GPL-2.0-or-later
 
-cmake_minimum_required(VERSION 3.16.3)
+cmake_minimum_required(VERSION 3.22)
 
 set(CMAKE_CXX_STANDARD 23)
 set(CMAKE_CXX_STANDARD_REQUIRED True)
@@ -38,7 +38,6 @@ function(create_target_directory_groups target_name)
     endforeach()
 endfunction()
 
-
 # Setup a custom clang-format target (if clang-format can be found) that will run
 # against all the src files. This should be used before making a pull request.
 # =======================================================================

README.md

@@ -5,14 +5,13 @@ SPDX-License-Identifier: GPL-2.0-or-later
 
 # shadPS4
 
-An early PS4 emulator for Windows and Linux written in C++
+shadPS4 is an early PS4 emulator for Windows and Linux written in C++
-by shadow , skmp , wheremyfoodat , GPUCode
 
 [Check us on twitter](https://twitter.com/shadps4 "Check us on twitter")
 
 # Status
 
-Early progress , a small amount of ps4 sdk demos and homebrew games working
+Early progress, a small amount of ps4 sdk demos and homebrew games working.
 
 # Why?
 
@@ -22,7 +21,7 @@ The project started as a fun project. Due to short free time, it will probably t
 
 ## Windows
 
-Check building instructions in [windows build](https://github.com/shadps4-emu/shadPS4/blob/main/documents/building-windows.md)
+Check building instructions in [windows build](https://github.com/shadps4-emu/shadPS4/blob/main/documents/windows_building.md)
 
 ## Linux
 
@@ -51,7 +50,6 @@ Logo is done by Xphalnos
 
 We currently accept any contribution, just open a pr and we will check it :)
 
-
 # Sister Projects
 - [Panda3DS](https://github.com/wheremyfoodat/Panda3DS): An multiplatform 3DS emulator from our co-author wheremyfoodat
-- [hydra](https://github.com/hydra-emu/hydra): An multisystem , multiplatform emulator (chip-8,GB,NES,N64) from Paris
+- [hydra](https://github.com/hydra-emu/hydra): An multisystem , multiplatform emulator (chip-8,GB,NES,N64) from Paris

documents/readme.txt

@@ -31,7 +31,6 @@ I would like to thank the following people for helping me so far , with coding o
 - skmp - or kornilios for being good old friend
 - PandaBad - our beloved stalker
 - emufan4568 - for advices
-- velocity - for talking 1-2 times per year on discord server . We miss you velocity 
+- velocity - for talking 1-2 times per year on discord server. We miss you velocity 
-
-- probably more , will include in the next readme :D
 
+- probably more , will include in the next readme :D

documents/windows_building.md

@@ -5,9 +5,9 @@ SPDX-License-Identifier: GPL-2.0-or-later
 
 # How to build shadps4 in windows 
 
-## Download VStudio Community 2022 17.9.5
+## Download Visual Studio Community 2022 17.9.5
 
-[VStudio 2022](https://visualstudio.microsoft.com/vs/)
+[Visual Studio 2022](https://visualstudio.microsoft.com/vs/)
 
 ## Requirements
 
@@ -22,4 +22,4 @@ Install the following
 
 - ## Compiling
 
-- Open vstudio and select the clang debug or clang release . It should compile just fine
+- Open Visual Studio and select the clang debug or clang release. It should compile just fine.

src/audio_core/sdl_audio.cpp

@@ -1,8 +1,8 @@
 // SPDX-FileCopyrightText: Copyright 2024 shadPS4 Emulator Project
 // SPDX-License-Identifier: GPL-2.0-or-later
 
-#include <common/assert.h>
+#include "common/assert.h"
-#include <core/libraries/error_codes.h>
+#include "core/libraries/error_codes.h"
 #include "sdl_audio.h"
 
 namespace Audio {

src/audio_core/sdl_audio.h

@@ -5,8 +5,8 @@
 
 #include <mutex>
 #include <SDL.h>
-#include <core/libraries/libsceaudioout.h>
 
+#include "src/core/libraries/libsceaudioout.h"
 #include "src/common/types.h"
 
 namespace Audio {

src/common/endian.h

@@ -15,9 +15,8 @@
 
 namespace Common {
 
-/**
+// Native endianness
- * Native endianness
+
- */
 template <typename T>
 using NativeEndian = T;
 
@@ -239,4 +238,4 @@ using u64_be = Common::BigEndian<u64>;
 
 using u16_le = Common::LittleEndian<u16>;
 using u32_le = Common::LittleEndian<u32>;
-using u64_le = Common::LittleEndian<u64>;
+using u64_le = Common::LittleEndian<u64>;

src/common/logging/backend.cpp

@@ -55,9 +55,8 @@ private:
     std::atomic_bool enabled{true};
 };
 
-/**
+// Backend that writes to a file passed into the constructor
- * Backend that writes to a file passed into the constructor
+
- */
 class FileBackend {
 public:
     explicit FileBackend(const std::filesystem::path& filename)
@@ -117,9 +116,8 @@ public:
 
 bool initialization_in_progress_suppress_logging = true;
 
-/**
+// Static state as a singleton.
- * Static state as a singleton.
+
- */
 class Impl {
 public:
     static Impl& Instance() {

src/common/logging/filter.h

@@ -16,9 +16,8 @@ namespace Common::Log {
  */
 const char* GetLogClassName(Class log_class);
 
-/**
+// Returns the name of the passed log level as a C-string.
- * Returns the name of the passed log level as a C-string.
+
- */
 const char* GetLevelName(Level log_level);
 
 /**

src/core/PS4/HLE/Graphics/video_out.cpp

@@ -17,7 +17,7 @@
 #include "core/hle/libraries/libscegnmdriver/libscegnmdriver.h"
 #include "core/loader/symbols_resolver.h"
 #include "emulator.h"
-#include "src/core/libraries/libsceuserservice.h"
+#include "core/libraries/libsceuserservice.h"
 
 namespace HLE::Libs::Graphics::VideoOut {
 

src/core/linker.cpp

@@ -2,7 +2,7 @@
 // SPDX-License-Identifier: GPL-2.0-or-later
 
 #include <Zydis/Zydis.h>
-#include <common/assert.h>
+#include "common/assert.h"
 #include "common/config.h"
 #include "common/logging/log.h"
 #include "common/path_util.h"

src/emulator.h

@@ -4,7 +4,7 @@
 #pragma once
 
 #include <SDL.h>
-#include <core/PS4/HLE/Graphics/graphics_ctx.h>
+#include "core/PS4/HLE/Graphics/graphics_ctx.h"
 
 #include <condition_variable>
 #include <mutex>

src/main.cpp

@@ -9,9 +9,9 @@
 #include <cstdio>
 #include <thread>
 
-#include <common/logging/log.h>
+#include "common/logging/log.h"
-#include <core/hle/libraries/libc/libc.h>
+#include "core/hle/libraries/libc/libc.h"
-#include <core/hle/libraries/libkernel/thread_management.h>
+#include "core/hle/libraries/libkernel/thread_management.h"
 #include "common/config.h"
 #include "common/discord.h"
 #include "common/logging/backend.h"

src/vulkan_util.cpp

@@ -1,19 +1,19 @@
 // SPDX-FileCopyrightText: Copyright 2024 shadPS4 Emulator Project
 // SPDX-License-Identifier: GPL-2.0-or-later
 
+#include <algorithm>
 #include <SDL_vulkan.h>
-#include <core/PS4/GPU/gpu_memory.h>
 #include <fmt/core.h>
 #include <vulkan/vk_enum_string_helper.h>
 #include <vulkan/vulkan_core.h>
+
+#include "core/PS4/GPU/gpu_memory.h"
 #include "common/assert.h"
 #include "common/debug.h"
 #include "common/logging/log.h"
 #include "common/singleton.h"
 #include "vulkan_util.h"
 
-#include <algorithm>
-
 void Graphics::Vulkan::vulkanCreate(Emu::WindowCtx* ctx) {
     Emu::VulkanExt ext;
     vulkanGetInstanceExtensions(&ext);

third-party/CMakeLists.txt

@@ -31,7 +31,4 @@ target_include_directories(xxhash INTERFACE xxhash)
 # Zydis
 option(ZYDIS_BUILD_TOOLS "" OFF)
 option(ZYDIS_BUILD_EXAMPLES "" OFF)
-add_subdirectory(zydis EXCLUDE_FROM_ALL)
+add_subdirectory(zydis EXCLUDE_FROM_ALL)
-
-
-