From 37fe4f96a52f938c24987b2de258a918f8561a54 Mon Sep 17 00:00:00 2001 From: IndecisiveTurtle <47210458+raphaelthegreat@users.noreply.github.com> Date: Mon, 14 Jul 2025 18:12:04 +0300 Subject: [PATCH] vk_graphics_pipeline: Move warning to pipeline --- src/video_core/renderer_vulkan/vk_graphics_pipeline.cpp | 6 ++++++ src/video_core/renderer_vulkan/vk_pipeline_cache.cpp | 5 ----- 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/src/video_core/renderer_vulkan/vk_graphics_pipeline.cpp b/src/video_core/renderer_vulkan/vk_graphics_pipeline.cpp index c11a2ac1b..12ac661db 100644 --- a/src/video_core/renderer_vulkan/vk_graphics_pipeline.cpp +++ b/src/video_core/renderer_vulkan/vk_graphics_pipeline.cpp @@ -158,6 +158,12 @@ GraphicsPipeline::GraphicsPipeline( }; if (!instance.IsDepthClampControlSupported()) { + if (key.depth_clamp_user_defined_range) { + LOG_WARNING(Render_Vulkan, + "Viewport uses custom clamp range zmin={}, zmax={} which cannot be " + "accurately emulated", + key.min_depth_clamp, key.max_depth_clamp); + } viewport_chain.unlink(); } if (!instance.IsDepthClipControlSupported()) { diff --git a/src/video_core/renderer_vulkan/vk_pipeline_cache.cpp b/src/video_core/renderer_vulkan/vk_pipeline_cache.cpp index aa59bff36..d4a933220 100644 --- a/src/video_core/renderer_vulkan/vk_pipeline_cache.cpp +++ b/src/video_core/renderer_vulkan/vk_pipeline_cache.cpp @@ -535,11 +535,6 @@ void PipelineCache::RefreshDepthClampRange() { if (!depth_clamp_can_use_viewport_range && !depth_clamp_is_same_on_all_viewports) { LOG_ERROR(Render_Vulkan, "Viewport depth clamping configuration cannot be accurately emulated"); - } else if (!depth_clamp_can_use_viewport_range && !instance.IsDepthClampControlSupported()) { - LOG_WARNING( - Render_Vulkan, - "Viewport uses custom clamp range zmin={}, zmax={} which cannot be accurately emulated", - zmin, zmax); } key.depth_clamp_user_defined_range = !depth_clamp_can_use_viewport_range;