From 76a76350c68bd5ee46f54bb59a050168e6c107aa Mon Sep 17 00:00:00 2001 From: Stephen Miller Date: Wed, 14 Aug 2024 10:33:29 -0500 Subject: [PATCH] Address Comments Verify parameters before calling the pthread_attr_setstack function. Swap uses of SCE prefix with ORBIS prefix. --- src/core/libraries/kernel/thread_management.cpp | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/src/core/libraries/kernel/thread_management.cpp b/src/core/libraries/kernel/thread_management.cpp index a9d24e2d1..63daa1d9e 100644 --- a/src/core/libraries/kernel/thread_management.cpp +++ b/src/core/libraries/kernel/thread_management.cpp @@ -1087,13 +1087,16 @@ int PS4_SYSV_ABI scePthreadAttrGetstack(ScePthreadAttr* attr, void** addr, size_ } int PS4_SYSV_ABI scePthreadAttrSetstack(ScePthreadAttr* attr, void* addr, size_t size) { + if (attr == nullptr || *attr == nullptr || addr == nullptr || size > 0x4000) { + return ORBIS_KERNEL_ERROR_EINVAL; + } int result = pthread_attr_setstack(&(*attr)->pth_attr, addr, size); LOG_INFO(Kernel_Pthread, "scePthreadAttrSetstack: result = {}", result); if (result == 0) { - return SCE_OK; + return ORBIS_OK; } - return SCE_KERNEL_ERROR_EINVAL; + return ORBIS_KERNEL_ERROR_EINVAL; } int PS4_SYSV_ABI scePthreadJoin(ScePthread thread, void** res) {