mirrors/shadPS4
1
0
Fork 0
mirror of https://github.com/shadps4-emu/shadPS4.git synced 2025-07-30 22:14:56 +00:00
Code Issues Packages Projects Releases Wiki Activity

texture_cache: detiler: prefer host memory for large buffers upload

Browse Source
This commit is contained in:
psucien 2024-07-27 22:42:05 +02:00
parent 1639e809b6
commit 80d93680fc
1 changed files with 9 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
src/video_core/texture_cache/tile_manager.cpp
View File

@ -326,11 +326,13 @@ TileManager::ScratchBuffer TileManager::AllocBuffer(u32 size, bool is_storage /*
.usage = usage, .usage = usage,
}; };
const VmaAllocationCreateInfo alloc_info{ const bool is_large_buffer = size > 128_MB;
VmaAllocationCreateInfo alloc_info{
.flags = !is_storage ? VMA_ALLOCATION_CREATE_HOST_ACCESS_ALLOW_TRANSFER_INSTEAD_BIT | .flags = !is_storage ? VMA_ALLOCATION_CREATE_HOST_ACCESS_ALLOW_TRANSFER_INSTEAD_BIT |
VMA_ALLOCATION_CREATE_HOST_ACCESS_SEQUENTIAL_WRITE_BIT VMA_ALLOCATION_CREATE_HOST_ACCESS_SEQUENTIAL_WRITE_BIT
: static_cast<VmaAllocationCreateFlags>(0), : static_cast<VmaAllocationCreateFlags>(0),
.usage = VMA_MEMORY_USAGE_AUTO_PREFER_DEVICE, .usage = is_large_buffer ? VMA_MEMORY_USAGE_AUTO_PREFER_HOST
: VMA_MEMORY_USAGE_AUTO_PREFER_DEVICE,
.requiredFlags = !is_storage ? VK_MEMORY_PROPERTY_HOST_VISIBLE_BIT .requiredFlags = !is_storage ? VK_MEMORY_PROPERTY_HOST_VISIBLE_BIT
: static_cast<VkMemoryPropertyFlags>(0), : static_cast<VkMemoryPropertyFlags>(0),
}; };
@ -338,8 +340,9 @@ TileManager::ScratchBuffer TileManager::AllocBuffer(u32 size, bool is_storage /*
VkBuffer buffer; VkBuffer buffer;
VmaAllocation allocation; VmaAllocation allocation;
const auto buffer_ci_unsafe = static_cast<VkBufferCreateInfo>(buffer_ci); const auto buffer_ci_unsafe = static_cast<VkBufferCreateInfo>(buffer_ci);
vmaCreateBuffer(instance.GetAllocator(), &buffer_ci_unsafe, &alloc_info, &buffer, &allocation, const auto result = vmaCreateBuffer(instance.GetAllocator(), &buffer_ci_unsafe, &alloc_info,
nullptr); &buffer, &allocation, nullptr);
ASSERT(result == VK_SUCCESS);
return {buffer, allocation}; return {buffer, allocation};
} }
@ -348,8 +351,8 @@ void TileManager::Upload(ScratchBuffer buffer, const void* data, size_t size) {
vmaGetAllocationInfo(instance.GetAllocator(), buffer.second, &alloc_info); vmaGetAllocationInfo(instance.GetAllocator(), buffer.second, &alloc_info);
ASSERT(size <= alloc_info.size); ASSERT(size <= alloc_info.size);
void* ptr{}; void* ptr{};
auto res = vmaMapMemory(instance.GetAllocator(), buffer.second, &ptr); const auto result = vmaMapMemory(instance.GetAllocator(), buffer.second, &ptr);
ASSERT(res == VK_SUCCESS); ASSERT(result == VK_SUCCESS);
std::memcpy(ptr, data, size); std::memcpy(ptr, data, size);
vmaUnmapMemory(instance.GetAllocator(), buffer.second); vmaUnmapMemory(instance.GetAllocator(), buffer.second);
} }