From 8258a4b66ff55a736417bc9131af80825b62d84f Mon Sep 17 00:00:00 2001 From: Stephen Miller <56742918+StevenMiller123@users.noreply.github.com> Date: Thu, 15 May 2025 13:42:28 -0500 Subject: [PATCH] Fix flag description --- src/core/memory.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/core/memory.cpp b/src/core/memory.cpp index f97023421..ab07147df 100644 --- a/src/core/memory.cpp +++ b/src/core/memory.cpp @@ -376,8 +376,8 @@ int MemoryManager::MapMemory(void** out_addr, VAddr virtual_addr, size_t size, M // To account for this, unmap any reserved areas within this mapping range first. auto unmap_addr = mapped_addr; auto unmap_size = size; - // If flag NoOverwrite is provided, allow overwriting mapped VMAs. - // Otherwise, we can only overwrite unmapped or reserved VMAs. + // If flag NoOverwrite is provided, don't overwrite mapped VMAs. + // When it isn't provided, VMAs can be overwritten regardless of if they're mapped. auto should_overwrite = False(flags & MemoryMapFlags::NoOverwrite) || !vma.IsMapped(); while (should_overwrite && unmap_addr < mapped_addr + size && remaining_size < size) { auto unmapped = UnmapBytesFromEntry(unmap_addr, vma, unmap_size);