From 8c256ca6b552c7d8037c9c1a2ecccb3aa308c633 Mon Sep 17 00:00:00 2001
From: tGecko <tGecko@proton.me>
Date: Sat, 28 Sep 2024 18:12:30 +0200
Subject: [PATCH] combine functions

---
 src/qt_gui/settings_dialog.cpp | 19 ++++++++-----------
 1 file changed, 8 insertions(+), 11 deletions(-)

diff --git a/src/qt_gui/settings_dialog.cpp b/src/qt_gui/settings_dialog.cpp
index d32876d68..f8214f298 100644
--- a/src/qt_gui/settings_dialog.cpp
+++ b/src/qt_gui/settings_dialog.cpp
@@ -140,20 +140,17 @@ SettingsDialog::SettingsDialog(std::span<const QString> physical_devices, QWidge
             checkUpdate->exec();
         });
 
-        connect(ui->playBGMCheckBox, &QCheckBox::stateChanged, this,
-                [](int val) { Config::setPlayBGM(val); });
-
-        connect(ui->BGMVolumeSlider, &QSlider::valueChanged, this,
-                [](float val) { Config::setBGMvolume(val); });
-
-        connect(ui->BGMVolumeSlider, &QSlider::valueChanged, this,
-                [](float val) { BackgroundMusicPlayer::getInstance().setVolume(val); });
-
-        connect(ui->playBGMCheckBox, &QCheckBox::stateChanged, this, [this](int state) {
-            if (state == Qt::Unchecked) {
+        connect(ui->playBGMCheckBox, &QCheckBox::stateChanged, this, [](int val) {
+            Config::setPlayBGM(val);
+            if (val == Qt::Unchecked) {
                 BackgroundMusicPlayer::getInstance().stopMusic();
             }
         });
+
+        connect(ui->BGMVolumeSlider, &QSlider::valueChanged, this, [](float val) {
+            Config::setBGMvolume(val);
+            BackgroundMusicPlayer::getInstance().setVolume(val);
+        });
     }
 
     // GPU TAB