From a0a439cd55c6d2975e409bdf31991232f78f8f3d Mon Sep 17 00:00:00 2001
From: rainmakerv2 <30595646+rainmakerv3@users.noreply.github.com>
Date: Sun, 15 Jun 2025 06:37:46 +0800
Subject: [PATCH] cleanup

---
 src/qt_gui/kbm_gui.cpp | 17 ++++++++---------
 1 file changed, 8 insertions(+), 9 deletions(-)

diff --git a/src/qt_gui/kbm_gui.cpp b/src/qt_gui/kbm_gui.cpp
index f241be8dc..ddbe0540b 100644
--- a/src/qt_gui/kbm_gui.cpp
+++ b/src/qt_gui/kbm_gui.cpp
@@ -373,28 +373,27 @@ void KBMSettings::SaveKBMConfig(bool CloseOnSave) {
 
     // Prevent duplicate inputs for KBM as this breaks the engine
     bool duplicateFound = false;
-    QSet<QString> duplicateInputs;
+    QSet<QString> duplicateMappings;
     for (auto it = inputs.begin(); it != inputs.end(); ++it) {
         if (std::find(it + 1, inputs.end(), *it) != inputs.end()) {
             duplicateFound = true;
-            duplicateInputs.insert(QString::fromStdString(*it));
+            duplicateMappings.insert(QString::fromStdString(*it));
         }
     }
 
     if (duplicateFound) {
-        QStringList DuplicateButtons;
-        for (QString i : duplicateInputs) {
-            for (const auto& j : ButtonsList) {
-                if (j->text() == i)
-                    DuplicateButtons.append(j->objectName() + " - " + i);
+        QStringList duplicatesList;
+        for (const QString mapping : duplicateMappings) {
+            for (const auto& button : ButtonsList) {
+                if (button->text() == mapping)
+                    duplicatesList.append(button->objectName() + " - " + mapping);
             }
         }
-        QString DuplicateList = DuplicateButtons.join("\n");
         QMessageBox::information(
             this, tr("Unable to Save"),
             QString(tr("Cannot bind any unique input more than once. "
                        "Duplicate inputs mapped to the following buttons:\n\n%1")
-                        .arg(DuplicateList)));
+                        .arg(duplicatesList.join("\n"))));
         return;
     }