From bdb345bbed808305c124c82d287e55811a8c04ab Mon Sep 17 00:00:00 2001
From: mailwl <mailwl@gmail.com>
Date: Fri, 9 May 2025 10:06:54 +0300
Subject: [PATCH] remove magic constant

---
 src/core/libraries/signin_dialog/signindialog.cpp |  8 ++++----
 src/core/libraries/signin_dialog/signindialog.h   | 11 +++++++++--
 2 files changed, 13 insertions(+), 6 deletions(-)

diff --git a/src/core/libraries/signin_dialog/signindialog.cpp b/src/core/libraries/signin_dialog/signindialog.cpp
index 8026962d6..e59aa8d5b 100644
--- a/src/core/libraries/signin_dialog/signindialog.cpp
+++ b/src/core/libraries/signin_dialog/signindialog.cpp
@@ -19,14 +19,14 @@ s32 PS4_SYSV_ABI sceSigninDialogOpen() {
     return ORBIS_OK;
 }
 
-s32 PS4_SYSV_ABI sceSigninDialogGetStatus() {
+Status PS4_SYSV_ABI sceSigninDialogGetStatus() {
     LOG_ERROR(Lib_SigninDialog, "(STUBBED) called");
-    return ORBIS_OK;
+    return Status::FINISHED;
 }
 
-s32 PS4_SYSV_ABI sceSigninDialogUpdateStatus() {
+Status PS4_SYSV_ABI sceSigninDialogUpdateStatus() {
     LOG_ERROR(Lib_SigninDialog, "(STUBBED) called");
-    return 3;
+    return Status::FINISHED;
 }
 
 s32 PS4_SYSV_ABI sceSigninDialogGetResult() {
diff --git a/src/core/libraries/signin_dialog/signindialog.h b/src/core/libraries/signin_dialog/signindialog.h
index 4e510e4e0..8726ad1f6 100644
--- a/src/core/libraries/signin_dialog/signindialog.h
+++ b/src/core/libraries/signin_dialog/signindialog.h
@@ -8,12 +8,19 @@ namespace Core::Loader {
 class SymbolsResolver;
 }
 
+enum class Status : u32 {
+    NONE = 0,
+    INITIALIZED = 1,
+    RUNNING = 2,
+    FINISHED = 3,
+};
+
 namespace Libraries::SigninDialog {
 
 s32 PS4_SYSV_ABI sceSigninDialogInitialize();
 s32 PS4_SYSV_ABI sceSigninDialogOpen();
-s32 PS4_SYSV_ABI sceSigninDialogGetStatus();
-s32 PS4_SYSV_ABI sceSigninDialogUpdateStatus();
+Status PS4_SYSV_ABI sceSigninDialogGetStatus();
+Status PS4_SYSV_ABI sceSigninDialogUpdateStatus();
 s32 PS4_SYSV_ABI sceSigninDialogGetResult();
 s32 PS4_SYSV_ABI sceSigninDialogClose();
 s32 PS4_SYSV_ABI sceSigninDialogTerminate();