Rename and fixups

This commit is contained in:
Lander Gallastegi 2025-06-20 01:24:35 +02:00
parent 6e5961c1b0
commit d10ad7e79b
3 changed files with 12 additions and 7 deletions

View File

@ -184,8 +184,13 @@ private:
void UpdateProtection() { void UpdateProtection() {
RENDERER_TRACE; RENDERER_TRACE;
RegionBits mask = cpu ^ writeable; RegionBits mask = cpu ^ writeable;
if (mask.None()) {
return; // No changes to the CPU tracking state
}
writeable = cpu; writeable = cpu;
tracker->UpdatePageWatchersMasked<add_to_tracker>(cpu_addr, mask); tracker->UpdatePageWatchersForRegion<add_to_tracker>(cpu_addr, mask);
} }
#ifdef PTHREAD_ADAPTIVE_MUTEX_INITIALIZER_NP #ifdef PTHREAD_ADAPTIVE_MUTEX_INITIALIZER_NP

View File

@ -241,7 +241,7 @@ struct PageManager::Impl {
} }
template <bool track> template <bool track>
void UpdatePageWatchersMasked(VAddr base_addr, RegionBits& mask) { void UpdatePageWatchersForRegion(VAddr base_addr, RegionBits& mask) {
RENDERER_TRACE; RENDERER_TRACE;
auto start_range = mask.FirstRange(); auto start_range = mask.FirstRange();
auto end_range = mask.LastRange(); auto end_range = mask.LastRange();
@ -331,13 +331,13 @@ void PageManager::UpdatePageWatchers(VAddr addr, u64 size) const {
} }
template <bool track> template <bool track>
void PageManager::UpdatePageWatchersMasked(VAddr base_addr, RegionBits& mask) const { void PageManager::UpdatePageWatchersForRegion(VAddr base_addr, RegionBits& mask) const {
impl->UpdatePageWatchersMasked<track>(base_addr, mask); impl->UpdatePageWatchersForRegion<track>(base_addr, mask);
} }
template void PageManager::UpdatePageWatchers<true>(VAddr addr, u64 size) const; template void PageManager::UpdatePageWatchers<true>(VAddr addr, u64 size) const;
template void PageManager::UpdatePageWatchers<false>(VAddr addr, u64 size) const; template void PageManager::UpdatePageWatchers<false>(VAddr addr, u64 size) const;
template void PageManager::UpdatePageWatchersMasked<true>(VAddr base_addr, RegionBits& mask) const; template void PageManager::UpdatePageWatchersForRegion<true>(VAddr base_addr, RegionBits& mask) const;
template void PageManager::UpdatePageWatchersMasked<false>(VAddr base_addr, RegionBits& mask) const; template void PageManager::UpdatePageWatchersForRegion<false>(VAddr base_addr, RegionBits& mask) const;
} // namespace VideoCore } // namespace VideoCore

View File

@ -35,7 +35,7 @@ public:
/// Updates watches in the pages touching the specified region /// Updates watches in the pages touching the specified region
/// using a mask. /// using a mask.
template <bool track> template <bool track>
void UpdatePageWatchersMasked(VAddr base_addr, RegionBits& mask) const; void UpdatePageWatchersForRegion(VAddr base_addr, RegionBits& mask) const;
/// Returns page aligned address. /// Returns page aligned address.
static constexpr VAddr GetPageAddr(VAddr addr) { static constexpr VAddr GetPageAddr(VAddr addr) {