From e7ffdaec2ba95dff25423de162f8741a2e9adde8 Mon Sep 17 00:00:00 2001
From: squidbus <175574877+squidbus@users.noreply.github.com>
Date: Mon, 30 Sep 2024 04:35:00 -0700
Subject: [PATCH] shader_recompiler: Don't bitcast on SetAttribute unless
 integer target.

---
 .../backend/spirv/emit_spirv_context_get_set.cpp | 16 ++++++++++------
 1 file changed, 10 insertions(+), 6 deletions(-)

diff --git a/src/shader_recompiler/backend/spirv/emit_spirv_context_get_set.cpp b/src/shader_recompiler/backend/spirv/emit_spirv_context_get_set.cpp
index 4dd82b316..b6bf1eed6 100644
--- a/src/shader_recompiler/backend/spirv/emit_spirv_context_get_set.cpp
+++ b/src/shader_recompiler/backend/spirv/emit_spirv_context_get_set.cpp
@@ -85,11 +85,11 @@ Id OutputAttrPointer(EmitContext& ctx, IR::Attribute attr, u32 element) {
     }
 }
 
-Id OutputAttrComponentType(EmitContext& ctx, IR::Attribute attr) {
+std::pair<Id, bool> OutputAttrComponentType(EmitContext& ctx, IR::Attribute attr) {
     if (IR::IsParam(attr)) {
         const u32 index{u32(attr) - u32(IR::Attribute::Param0)};
         const auto& info{ctx.output_params.at(index)};
-        return info.component_type;
+        return {info.component_type, info.is_integer};
     }
     switch (attr) {
     case IR::Attribute::Position0:
@@ -97,7 +97,7 @@ Id OutputAttrComponentType(EmitContext& ctx, IR::Attribute attr) {
     case IR::Attribute::Position2:
     case IR::Attribute::Position3:
     case IR::Attribute::Depth:
-        return ctx.F32[1];
+        return {ctx.F32[1], false};
     case IR::Attribute::RenderTarget0:
     case IR::Attribute::RenderTarget1:
     case IR::Attribute::RenderTarget2:
@@ -108,7 +108,7 @@ Id OutputAttrComponentType(EmitContext& ctx, IR::Attribute attr) {
     case IR::Attribute::RenderTarget7: {
         const u32 index = u32(attr) - u32(IR::Attribute::RenderTarget0);
         const auto& info{ctx.frag_outputs.at(index)};
-        return info.component_type;
+        return {info.component_type, info.is_integer};
     }
     default:
         throw NotImplementedException("Write attribute {}", attr);
@@ -257,8 +257,12 @@ void EmitSetAttribute(EmitContext& ctx, IR::Attribute attr, Id value, u32 elemen
         return;
     }
     const Id pointer{OutputAttrPointer(ctx, attr, element)};
-    const Id component_type{OutputAttrComponentType(ctx, attr)};
-    ctx.OpStore(pointer, ctx.OpBitcast(component_type, value));
+    const auto component_type{OutputAttrComponentType(ctx, attr)};
+    if (component_type.second) {
+        ctx.OpStore(pointer, ctx.OpBitcast(component_type.first, value));
+    } else {
+        ctx.OpStore(pointer, value);
+    }
 }
 
 template <u32 N>